Get path for first page of paginated pages#219
Open
cmbuckley wants to merge 6 commits intojekyll:mainfrom
Open
Get path for first page of paginated pages#219cmbuckley wants to merge 6 commits intojekyll:mainfrom
cmbuckley wants to merge 6 commits intojekyll:mainfrom
Conversation
ashmaroli
changed the title
ashmaroli
reviewed
Dec 22, 2021
Member
|
Okay. The existing tests pass. Therefore, no regressions. |
Contributor
Author
|
Hmm, not what I was expecting. Although I note that the tests are running against Jekyll 4.2.1 and I was using 3.9.0 to match the version in |
ashmaroli
reviewed
Dec 23, 2021
Member
|
Seems like a useful bug fix. |
cmbuckley
force-pushed
the
pagination-fix
branch
from
5cebadd to
16e82e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a page is paginated, the edit link includes the pagination part of the URL. This grabs the path from the first page of the pagination collection.
I would appreciate some help with the tests as I'm not familiar enough with Ruby.
Closes #213